Mark

IPS Staff
  • Content count

    30842
  • Joined

  • Last visited


About Mark

  • Rank
    I dropped the "iggy"
  • Birthday March 04

IPS Marketplace

  • Resources Contributor Total file submissions: 5

Profile Information

  • Gender Male
  • Location Colchester, UK

Recent Profile Visitors


128,335 profile views

Mark's Activity

  1. Mark added a comment: Nexus - Subscription expiration date   

    Changed Status to Closed
  2. Mark added a comment: Nexus - Subscription expiration date   

    This is intentional right now, but something we might look into for a future version.
    After all, the user could just not pay the renewal invoice and just go buy it again.
  3. Mark added a comment: Quote Inline Notifications not grouping properly   

    Changed Status to Fixed
  4. Mark added a comment: Quote Inline Notifications not grouping properly   

    Mine
  5. Mark added a comment: [RC 6] NO_TEMPLATE_FILE   

    Can you also upload a zip of your development files (the folder in /plugins)?
  6. Mark added a post in a topic: Update Checker   

    Of course  
    Pretty much all URL handling in IPS4 is handled by the \IPS\Http\Url class which is super-clever at figuring things like that out. The code to call the URL you specify is:
    $url = \IPS\Http\Url::external( $row['url'] )->setQueryString( 'version', $row['current'] ); $response = $url->request()->get()->decodeJson(); In applications/core/tasks/updatecheck.php
  7. Mark added a comment: [RC5] [Commerce] [Support] Filters & Statuses   

    Will be fixed in next release
  8. Mark added a comment: recentEmoticons   

    Changed Status to Future
  9. Mark added a bug in Bug Tracker   

    recentEmoticons
    I had a ticket today where ModSecurity was triggering a block because of content it perceived as dangerous in the recentEmoticons cookie.
    While I have advised the customer to disable that rule, which has fixed the issue, it does seem the format we use for the recentEmoticons cookie is unusual and could probably be simplified to prevent something like this happening again.
    This is just a reminder to to look into that whenever we get a chance - since it's not actually a bug, we don't need to worry about it immediately.
    • 1 reply
    • 31 views
  10. Mark added a comment: [RC5] All previous reported content is missing in mod CP   

    Changed Status to Pending
  11. Mark added a comment: [RC5] All previous reported content is missing in mod CP   

    \IPS\core\setup\upg_40000\Upgrade::step11()
    /* @note - If the content item class isn't present or the data hasn't been updated yet, this might not work - evaluate */ try { $content = $className::load( $report['exdat3'] ? $report['exdat2'] : $report['exdat1'] ); $insert['author'] = $content->mapped('author'); $insert['perm_id'] = $content->permId(); } catch( \Exception $e ) {} The topics/posts tables haven't been renamed at this point so perm_id (and author) don't get set and the reports subsequently don't show.
    We have a couple of options, though since we are specifically only handling reports from our apps (reports for third party apps get deleted) - I would just replace the $className::load() call with database queries, and take into account that the the topics/posts tables won't have been renamed yet. Alternatively, we could move this to another part of the upgrader, or a background queue task after the upgrade is complete.
    Incidentally: there is also a note about records from Pages not being right, and in general when I tested this, converted reports seemed weird - I had a report where the content of the report was actually the content of the reported post, not what I entered when submitting the post, for example. We should test reports of everything (including comments) across all apps.
     
  12. Mark added a comment: [RC6] Call to undefined method Memcached::close()   

    Changed Status to Fixed
  13. Mark added a comment: No e-mails sent for quoted replies in followed topics   

    Changed Status to Future
  14. Mark added a comment: No e-mails sent for quoted replies in followed topics   

    The possible scenarios are:
    Notification preference when someone replies Notification preference when someone mentions me Expected behaviour Current behaviour Email Email I get one email I get one email Email Inline ?? I get an email and an inline notification ?? I get an inline notification Email None I get one email I get nothing Inline Email ?? I get an email and an inline notification ?? I get an email Inline Inline I get one inline notification I get one inline notification Inline None I get one inline notification I get nothing Following with "none" option Email I get one email I get one email Following with "none" option Inline I get one inline notification I get one inline notification Following with "none" option None I get nothing I get nothing Not following Email I get one email I get one email Not following Inline I get one inline notification I get one inline notification Not following None I get nothing I get nothing This is actually a simplified table. It is possible to have separate preferences for quoting and mentioning and of course you can be both mentioned and quoted in a post in a topic you're following, and the same issue applies there.
    This will be tricky, but I have some ideas about how to go about this. We're going to "Future" this for now because we're not going to make such substantial adjustments in an RC, but will fix it in 4.0.1.
  15. Mark added a comment: Payout Withdraw funds rounding incorrectly   

    Changed Status to Fixed

Blogs


  1. IPS News

    • 507
      entries
    • 13971
      comments
    • 4831755
      views