MrStormyNights

+Clients
  • Content count

    63
  • Joined

  • Last visited


2 Followers



About MrStormyNights

  • Rank
    IPB Member
  • Birthday 09/10/1961

Recent Profile Visitors


7,695 profile views

MrStormyNights's Activity

  1. MrStormyNights added a record in IP.Board   

    Guest Name not Escaped
    It seems that usernames of guests are not properly escaped before being displayed in a post on the forum. This means that html can be injected into a forum page through the username of a guest.
     
    The code to reproduce this problem would look something like this:
     [code=auto:0] $ips = ipsRegistry::instance(); #... (irrelevant parts cut out) $a = new IPSMember(); $post = $ips->getClass( 'classPost' );   $post->setAuthor( $a->setUpGuest( '<div>aaa</div>' ) ); #... $post->addTopic();[/code]
    Nor setUpGuest, nor setAuthor, nor the function that displays the username in the sidebar of a post escapes the < and the > in the username. This will result in a div element being displayed where the username of the guest is.
    • 0 replies
    • 0 views
  2. MrStormyNights added a comment: Deleting Sort By field in Front Page manager breaks Articles   

    I can think of several very easy ways to fix this without much code at all.

    1. Check the value for sort and if its null set it to the default as installed field.

    2. when you delete a field have it check the sort value and have it set back to default value if it equals the field your deleting. A little more code but not by that much.

    3. Supply a tool that can be uploaded that will fix this in case it happens, no code changes to forum required.

    4. Simply add a language variable to the delete screen and set it to a warning that deleting the default sort key will break the article system, and maybe even a note that there is a tool supplied with the forum if this happens if a tool is created to resolve this.
  3. MrStormyNights added a record in IP.Content   

    Deleting Sort By field in Front Page manager breaks Articles
    If you create a new custom field in the Articles DB and set that new field as the Sort By field in front page manager and then subsequently delete that new field without first resetting the Sort By field the Articles system is unusable. You can no longer get to the from page manager to fix it. The articles also are not viewable on the web site.
    • 0 replies
    • 0 views
  4. MrStormyNights added a record in IP.Board   

    Manage Languages and ACP Restrictions Menu Wrapping
    The menus wrap horribly in Manage Languages and Manage ACP restrictions when you install several applications. See images below.

    [img]http://www.mechhq.net/image/IPBerrors/ACP_Restrictions.png[/img]
    [img]http://www.mechhq.net/image/IPBerrors/Manage_Languages.png[/img]
    • 0 replies
    • 0 views
  5. MrStormyNights added a comment: Forum Permissions not saving   

    [quote name='teraßyte' date='02 July 2009 - 09:02 AM']
    Maybe it is a limitation of your server for $_POST size
    [/quote]

    Well I have these values in php.ini:
    post_max_size => 16M => 16M
    upload_max_filesize => 8M => 8M
  6. MrStormyNights added a comment: Gallery Upgrade Failed   

    How do I correct this on my forum?
  7. MrStormyNights added a record in IP.Blog   

    Gallery Upgrade Failed
    While upgrading the gallery I received the following error:

    Warning: in_array() [function.in-array]: Wrong datatype for second argument in (forumdir)/admin/applications_addon/ips/blog/sources/lib/cblock_plugins.php on line 135

    I cannot recache skin sets without getting this error.

    This is a IPB 2.3.6 database that was upgraded to IPB 3 when the first upgrade path was available.

    Here is the SQL_Error_log from the cache directory:

    [code]===================================================
    Date: Mon, 18 May 2009 15:50:15 +0000
    Error Number: 1054
    Error: Unknown column '$' in 'where clause'
    IP Address: 173.28.203.149
    Page: /RHQInn3/admin/upgrade/index.php?app=upgrade&section=upgrade&do=caches&previous=members
    Debug: array (
    1 =>
    array (
    'file' => '(forumdir)/ips_kernel/classDb.php',
    'line' => 974,
    'function' => 'query',
    'class' => 'db_driver_mysql',
    ),
    3 =>
    array (
    'file' => '(forumdir)/admin/sources/template_plugins/tp_cblocks.php',
    'line' => 57,
    'function' => '__construct',
    'class' => 'cblock_plugins',
    ),
    4 =>
    array (
    'file' => '(forumdir)/ips_kernel/classTemplateEngine.php',
    'line' => 1052,
    'function' => 'runPlugin',
    'class' => 'tp_cblocks',
    ),
    5 =>
    array (
    'file' => NULL,
    'line' => NULL,
    'function' => '_processPluginTagsCallback',
    'class' => 'classTemplate',
    ),
    6 =>
    array (
    'file' => '(forumdir)/admin/sources/base/core.php',
    'line' => 3516,
    'function' => 'call_user_func',
    'class' => NULL,
    ),
    7 =>
    array (
    'file' => '(forumdir)/ips_kernel/classTemplateEngine.php',
    'line' => 925,
    'function' => 'replaceRecursively',
    'class' => 'IPSText',
    ),
    8 =>
    array (
    'file' => '(forumdir)/ips_kernel/classTemplateEngine.php',
    'line' => 369,
    'function' => '_processPluginTags',
    'class' => 'classTemplate',
    ),
    9 =>
    array (
    'file' => '(forumdir)/admin/sources/classes/skins/skinCaching.php',
    'line' => 209,
    'function' => 'convertHtmlToPhp',
    'class' => 'classTemplate',
    ),
    10 =>
    array (
    'file' => '(forumdir)/admin/setup/applications/upgrade/sections/upgrade.php',
    'line' => 1410,
    'function' => 'rebuildPHPTemplates',
    'class' => 'skinCaching',
    ),
    11 =>
    array (
    'file' => '(forumdir)/admin/setup/applications/upgrade/sections/upgrade.php',
    'line' => 201,
    'function' => 'install_caches',
    'class' => 'upgrade_upgrade',
    ),
    12 =>
    array (
    'file' => '(forumdir)/admin/setup/sources/base/ipsController_setup.php',
    'line' => 251,
    'function' => 'doExecute',
    'class' => 'upgrade_upgrade',
    ),
    )
    mySQL query error: SELECT * FROM ibf_blog_cblock_cache WHERE blog_id = $[/code]
    • 0 replies
    • 0 views
  8. MrStormyNights added a comment: 2.2.0 RC3 Image Replacement macros not being used.   

    ok, this was the default IPB skin, how do I get the skins updated to be correct then for the gallery? I did the upgrade and as I remember it did not ask me any questions about the skins and updating them?
  9. MrStormyNights added a comment: 2.2.0 RC3 Image Replacement macros not being used.   

    Here is an images that shows the buttons I am talking about. I have fixed the code to what I think it should be, however I have not added the missing images or the replacement macros as of yet so you see the replacement code and not an image.
    Gallery Issues Image

    For some reason when I click the link from here it results in a forbidden page but if I copy the url it goes to and put it in a new window it works? The address used above is the correct location for the image.
  10. MrStormyNights added a record in IP.Gallery   

    2.2.0 RC3 Image Replacement macros not being used.
    Gallery 2.2.0 RC3

    in sources\components_public\gallery\img_view.php
    Around Lines 953-1053 Get Special Buttons Section. Edit image, Move image, Pin, Unpin, Approve, Unapprove and Report Image all use a Language variable that is TEXT and not the replacement Macro. Delete Image is Hard Coded to the Text "Delete Image" and not using a Language Variable or the Replacement Macro Code. The E-Card Button in the code below is correct and does show the image. When you view an image the buttons do not show up, all you get is text.

    Are the replacement macros switching to be in the Language file or should these actually be used in the code below instead of the Language references?

    ALSO, There are no Replacement macros for some of these images when I view the Skin Replacement macros, so code needs added to add these on install of the gallery, PIN, UNPIN, Unapprove to name a few.



    CODE     /*-------------------------------------------------------------------------*/
        // Get special buttons
        /*-------------------------------------------------------------------------*/

        function get_special_buttons( $mode='cat' )
        {
            //-------------------------------------------------------
            // Edit Image Button
            //-------------------------------------------------------
            if( $this->is_moderator || ( $this->data['member_id'] == $this->ipsclass->member['id'] && $this->ipsclass->member['g_edit_own'] ) )
            {
                 $this->data['edit_button'] = $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=editimg&amp;img={$this->data['id']}{$media}", $this->ipsclass->lang['edit_post'] );
                 $this->data['mod_buttons'] = 1;
            }

            //-------------------------------------------------------
            // Move Image Button
            //-------------------------------------------------------
            if( ( $this->is_moderator || ( $this->data['member_id'] == $this->ipsclass->member['id'] && $this->ipsclass->member['g_move_own'] ) ) )
            {
                 $this->data['move_button'] = $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=moveimg&amp;img={$this->data['id']}", $this->ipsclass->lang['submit_move'] );
                 $this->data['mod_buttons'] = 1;
            }

            //-------------------------------------------------------
            // Delete Image Button
            //-------------------------------------------------------
            if( $this->is_moderator || ( $this->data['member_id'] == $this->ipsclass->member['id'] && $this->ipsclass->member['g_del_own'] ) )
            {
                 $this->data['delete_button'] = $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "java script:delete_img(\"?autocom=gallery&amp;req=delimg&amp;img={$this->data['id']}\")", 'Delete Image' );
                 $this->data['mod_buttons'] = 1;
            }

            //-------------------------------------------------------
            // Pin + Approve/Unapprove Image Button
            //-------------------------------------------------------
            if( $this->is_moderator )
            {
                 $this->data['pin_button'] = ( ! $this->data['pinned'] ) ?
                     $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=mod&amp;op=pin&amp;img={$this->data['id']}", $this->ipsclass->lang['pin_image'] ) :
                     $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=mod&amp;op=unpin&amp;img={$this->data['id']}", $this->ipsclass->lang['unpin_image'] );
                     
                 $this->data['approve_button'] = $this->data['approved'] ?
                     $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=gallerymmod&amp;galleryact=unapprove&amp;selectedimgids={$this->data['id']}&amp;img={$this->data['id']}", $this->ipsclass->lang['unapprove_image'] ) :
                     $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=gallerymmod&amp;galleryact=approve&amp;selectedimgids={$this->data['id']}&amp;img={$this->data['id']}", $this->ipsclass->lang['approve_image'] );

                 $this->data['mod_buttons'] = 1;
            }

            //-------------------------------------------------------
            // E-Card Button
            //-------------------------------------------------------
            if( $this->ipsclass->vars['gallery_use_ecards'] && $this->ipsclass->member['g_ecard'] )
            {
                 $this->data['ecard_button'] = $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=ecard&amp;img={$this->data['id']}", '<{GALLERY_ECARD}>' );
            }

    CODE         //-------------------------------------------------------
            // Report Image Button
            //-------------------------------------------------------
            if( ! $this->ipsclass->vars['gallery_disable_report_images'] AND ( $this->ipsclass->vars['gallery_guest_report'] OR $this->ipsclass->member['id'] > 0 ) )
            {
                $this->data['report_button'] = $this->ipsclass->compiled_templates['skin_gallery_global']->link_macro( "{$this->ipsclass->base_url}autocom=gallery&amp;req=mod&amp;op=reportimage&amp;img={$this->data['id']}", $this->ipsclass->lang['report_image'] );
    • 0 replies
    • 0 views

Status Feed