• Content count

  • Joined

  • Last visited

Grumpy's Activity

  1. Grumpy added a post in a topic: Fetching templates uses a large amount of mysql resource   

    I expect this not to be an issue for significant majority of the users but in goal of increasing performance & multi-server optimizations I am adding this feedback.
    Currently CCS fetches templates from the database on each page load despite any caching setup. I would suggest that if apc/xcache/etc which has local cache system, it should use them for templates as well on a very short timeouts.
    If the site is setup on multi servers, fetching ccs templates alone from the sql server can easily exceed 1gbps. And mysql will take up a lot of sockets writing to net.
    For example:
    /admin/applications_addon/ips/ccs/sources/pages.php Line ~182 and ~450
    $skinFile    = $this->DB->buildAndFetch( array( 'select' => 'cache_content', 'from' => 'ccs_template_cache', 'where' => "cache_type='full'" ) ); could be altered to: (semi pseudo-code here)
    if ($cache) {   $skinFile = $cache } else { $skinFile    = $this->DB->buildAndFetch( array( 'select' => 'cache_content', 'from' => 'ccs_template_cache', 'where' => "cache_type='full'" ) ); }  
  2. Grumpy added a record in IP.Content   

    Incorrect spoiler division in article comments creates incorrect div tag matches
    When someone writes a comment with incorrect spoiler tags, sometimes it creates bad match up html <div> tags causing layout to get messed up. (Browsers parse it as one extra closing div tag)
    Here is one sample case that I found from the database record (table: prefix_ccs_database_comments). I have removed text/image from the post.[code=auto:0] <div> <p>&nbsp;</p> <blockquote class="ipsBlockquote">TEXT_WAS_HERE <p>TEXT_WAS_HERE [spoiler]</p> <p><img src="IMAGE_URL_WAS_HERE" alt="IMAGE_NAME_WAS_HERE"></p> </blockquote> </div> <p>&nbsp;</p> <p>[/spoiler]</p> <p>TEXT_WAS_HERE</p> [/code]
    Strangely enough, I couldn't replicate when the same structure was used. Or a simpler version like...[code=:0] [quote][spoiler]text[/quote][/spoiler] [/code]
    It happened twice on record for me now. But both cases had a mismatching spoiler tag with a quote tag.
    • 0 replies
  3. Grumpy added a record in IP.Board   

    Display name allows name entirely made of space equivalent
    Users can currently change their display name to just a characters of [url=""]U+3000[/url] and similar which essentially are just blank, and making their name invisible.
    Copy/pasted right here:[code=auto:0] [/code]
    • 0 replies