Javascript selector in comments
Submitted bfarber, Apr 03 2012 02:38 PM | Last updated Apr 03 2012 02:38 PM
ips.comments.js has this
The functions are identical and perform the same exact action, so really we only need one. Setting that aside though, the second selector causes any page that has an <a> tag with rel='bookmark' (which is utilized inside the hFeed microformat) to throw the js prompt.
I believe this came up before and we intended to *change* the selector to the first one, rather than *add* it. We should be able to safely delete the second selector, and the associated function, without issue.
ipb.delegate.register('.post_id a[rel="bookmark"]', ipb.comments.showLinkToComment );
...
ipb.delegate.register('a[rel="bookmark"]', ipb.comments.showCommentLink );
The functions are identical and perform the same exact action, so really we only need one. Setting that aside though, the second selector causes any page that has an <a> tag with rel='bookmark' (which is utilized inside the hFeed microformat) to throw the js prompt.
I believe this came up before and we intended to *change* the selector to the first one, rather than *add* it. We should be able to safely delete the second selector, and the associated function, without issue.
| Status: | Fixed |
| Version: | 3.3.0 |
| Fixed In: | 3.3.2 |
0 Comments