Jump to content


Photo

Unsubscribe link broken in emails


The unsubscribe link in the emails is not being replaced properly:
You can unsubscribe at any time here: http://community.invisionpower.com/s=0

This was in a topic subscription email.

Status: Fixed
Version: 3.3.2
Fixed In: 3.3.3


13 Comments

I noticed this on 2 emails on here but I can't reproduce at all locally.
Photo
markopolo2002
May 14 2012 06:53 AM
Are you kidding me? I've just reported a mod as broken because of this issue. It was a newsletter mod from Headstand (http://community.inv...s/page__st__140) which sends newsletters out with the correct URL's the first time (which is manual), thereafter the URL's to downloads, topics, etc all look like how the links are in the first post. Basically, it would appear anything which is scheduled messes up the URL's, anything triggered manually seems to work OK ??
I believe both emails where I noticed this issue were direct ones but let me double-check just in case..
Photo
markopolo2002
May 14 2012 07:08 AM
Here's the notification I received just recently from following one of my own forums:

[attachment=39572:14-05-2012 13-07-53.png]
Photo
markopolo2002
May 14 2012 07:58 AM
Even more issues (unless this one was already raised) ....

[attachment=39575:14-05-2012 13-56-18.png]

That link was as follows:
http://community.invisionpower.com/unsubscribe/Zm9ydW1zO3RvcGljczszNTExMTQ7MTE2OTI5OzExNjkyOTtmcmVld2FyZWJiQGhvdG1haWwuY28udWs%2c/

Which gives us:
[attachment=39576:14-05-2012 13-57-38.png]
Photo
markopolo2002
May 14 2012 07:59 AM
Also, just so you are aware, I'm currently using 3.3.2
Photo
markopolo2002
May 14 2012 01:41 PM
Is there a potential fix for this guys? ... everytime a mail goes out from my site it's showing this nonsense :)
Can't reproduce locally or on our forums.

Can you submit a ticket please?
Photo
markopolo2002
May 15 2012 02:57 AM
Will raise it right now Matt, thanks
Thanks - all fixed.

admin/sources/classes/output/publicOutput.php

Line 2041

if ( strstr( $url, 's=0' ) )
{
 $url = preg_replace( "/s=0(&|&)/", '', $url );
 $_s = '';
 }

Thanks - all fixed.admin/sources/classes/output/publicOutput.php Line 2041

if ( strstr( $url, 's=0' ) ){ $url = preg_replace( "/s=0(&|&)/", '', $url ); $_s = ''; }


line 2041 does not have that

Would you please put what exactly replaced wit?

Thanks
Possibly insert the code at line 2041?
Photo
CheersnGears
May 16 2012 02:09 PM
Mind uploading a fixed file for the non-coders around here?