Jump to content


Photo

IPB2 upgrades


eh.. I forgot to think of this before.. If you upgrade from IPB2.. We've got it fixed now, apparently, so that it adds an upgrade_history entry up to IPB 3.1.4..

Problem is.. There's no core_applications entry.

That's something of a problem. No good way to handle it, either. If it's an upgrade from IPB2, we need to add it in.. BUT.. We can't if it's from 3.0.0 or higher.

Add the query in the 3.1.3 to 3.1.4 upgrade If it doesn't exist?

Status: Fixed
Version: 3.2.1
Fixed In: 3.2.2


3 Comments

Not tested
I spent over an hour rolling this issue around in my head to determine how to best proceed.

On the one hand, you're right - if core_applications entry isn't there you still can't upgrade it later, creating problems for those who accidentally forgot to upload calendar.
On the other hand, if you intentionally did not upload calendar because you don't wish to use it, automatically inserting a core_applications entry for it defeats the point.

Additionally, you can't use the application and it might be confusing for a user to see the application there in the ACP, but it is not functional and if enabled will cause errors.

I decided to go ahead and insert the core_applications entry, with the app disabled, as this will likely create less problems for techs and users who forgot that calendar is separated. For those intentionally not updating it, they can still delete the application from the ACP. We will have to evaluate if this has any negative impact/confusion/etc.
The app is there.. Albeit an older version(3.1.4 will always be there anytime an install was done originally prior to 3.2.0). Without the app there in core_apps, people try to install(because, that's the logical flow..), and that REALLY makes a mess of things, including the possible loss of data if they select to drop tables. I agree, there's no good way to do this, but this is probably the safest way to prevent any possible loss of data, and make upgrading it, if the user chooses to do so, a fairly easy process.

Removal is another story, but.. That should be rather few and far between.