Jump to content


Photo

Long Usernames on Mobile Skin


Long usernames are causing distortion in the Kick / Ban / Leave menu for Chat on the Mobile skin. We already truncate usernames to 16 characters, however this doesn't appear to be enough.

http://dl.dropbox.co...12 56 26 PM.png

Changing this:

<span class='names'><if test="hasname:|:$data['member']['members_display_name']"><span title='{$data['member']['members_display_name']}'><if test="formatname:|:$this->settings['ipschat_format_names']">{IPSMember::makeNameFormatted( IPSText::truncate( $data['member']['members_display_name'], 16 ), $data['member']['member_group_id'] )}<else />{IPSText::truncate( $data['member']['members_display_name'], 16 )}</if></span><else />{$data['user_name']}</if></span>

To this:

<span class='names'><if test="hasname:|:$data['member']['members_display_name']"><span title='{$data['member']['members_display_name']}'><if test="formatname:|:$this->settings['ipschat_format_names']">{IPSMember::makeNameFormatted( IPSText::truncate( $data['member']['members_display_name'], 8 ), $data['member']['member_group_id'] )}<else />{IPSText::truncate( $data['member']['members_display_name'], 8 )}</if></span><else />{$data['user_name']}</if></span>

Should fix it for mobile devices with smaller resolutions (older iPhone's and iPod's, I believe, would be the case here). More or less just cutting the truncation down to 8 characters instead of 16. I don't think it necessary to go any shorter than that, though.

Status: Fixed
Version: 1.4.1
Fixed In: 1.4.2


4 Comments

Meh, I'll give some thought to this before making any changes. 8 characters of a username seems almost pointless. We can do something else to resolve this I imagine.
Eh... I just figured most usernames aren't over 8 characters anyway. And if they are, it's not by much.
Updating Fixed In to: 0

Well, I can't actually reproduce the issue in Chrome or Firefox, but I've made a couple changes that should help

 

1) Shortened "Kick User" to "Kick" and "Ban User" to "Ban"

2) Set the display of the name to inline-block which should hopefully force wrapping

Updating Fixed In to: 1.4.2
Updating Status to: Fixed

-