Jump to content


Photo

comments not allowed...


Could swear this was mentioned before, could also swear this was checked before 2.3.x
<div id='commentsStart' class='ipsBox'>
	    <div class='ipsBox_container ipsPad'>
			    <h2 class='ipsType_subtitle'>{$data['comments']['count']} {$this->lang->words['comment_block']}</h2>
			    <div class='comment_wrap'>
					    {$data['comments']['html']}
			    </div>
	    </div>
</div>
client has comments disabled, would never use them on this database.

<if test="commentsEnabled:|:$data['database']['database_comments'] || $data['comments']['count']">
<div id='commentsStart' class='ipsBox'>
	    <div class='ipsBox_container ipsPad'>
			    <h2 class='ipsType_subtitle'>{$data['comments']['count']} {$this->lang->words['comment_block']}</h2>
			    <div class='comment_wrap'>
					    {$data['comments']['html']}
			    </div>
	    </div>
</div>
</if>
maybe? if it is not allowed and never used, it is a bug to show the html.

Status: Fixed
Version: 2.3.2
Fixed In: 2.3.3


4 Comments

Photo
Marcher Technologies
Aug 12 2012 06:22 PM
bah, version >.< 2.3.2
Updating Status to: Confirmed - Skin Issue
Updating Version to: 2.3.2

There is no more "database_comments" column - we just check if anyone has permission to comment (if no one does, it is disabled).
Photo
Marcher Technologies
Aug 13 2012 02:18 PM

Updating Status to: Confirmed - Skin Issue
Updating Version to: 2.3.2

There is no more "database_comments" column - we just check if anyone has permission to comment (if no one does, it is disabled).


I am quite aware the column is gone, I am also quite aware that is valid code as you check the perm matrix to see if anyone *can* and set that variable as a result ;)
Updating Fixed In to: 2.3.3
Updating Status to: Fixed

You're right, though I just went with

<if test="$data['database']['database_comments']">

I think if you disable all permission for comments, you're trying to shut them off, so we might as well hide existing ones. That's going to be an opinion-based approach no matter what way you cut it though.
    • Marcher Technologies likes this