Jump to content


Photo

No if(!defined) check for DATABASE_FURL_MARKER


In Tools/index.php there is no check if "DATABASE_FURL_MARKER" is defined.

With the new constants.php, shouldn't it be :


/**
 * This is the flag in the URL for database friendly URLs.  You must have a flag here
 * (i.e. do not try to set this as an empty string).  This also needs to be updated in
 * admin/applications_addon/ips/ccs/app_class_ccs.php as well.
 */
if (!defined('DATABASE_FURL_MARKER')) {
define( 'DATABASE_FURL_MARKER', '_' );
}


as otherwise could it not cause a clash/error?

Status: Fixed
Version: 2.3.1
Fixed In: 2.3.2


1 Comments

The new constants.php file is supposed to have only constants available in the initdata.php file but I guess we can use it for that too as it would help reduce errors on upgrades. I'll leave this to Brandon and let him decide.