Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

Issue information

Issue ID
#019675
Status
Unconfirmed
Version
-
Fixed in
-

Issue Confirmations

Yes (0)No (0)

0

Buggy code for external data extensions

Posted by bfarber on 16 November 2009 - 07:36 PM

In convergeAuthenticate, for extensions support, it has this

								if (class_exists($productCode.'_custom'))
								{
									if ( ! in_array($productCode, $loadedClasses) )
									{
										$class = $productCode.'_custom';
										$loadedClasses[$productCode] = new $class;
									}
									if ($loadedClasses[$productCode]->authType == 'username')
									{
										$addToRequest['auth'] = $member['converge_username'];
									}
									else
									{
										$addToRequest['auth'] = $member['converge_email'];
									}
								}
								else
								{
									$addToRequest['email_address'] = $member['converge_email'];
								}

After much debugging I found the problem. $member is not defined, the member data is in $row. Changing to $row properly populates auth in the request.

converge_master/server_functions.php

Back to top

bfarber

Nov 16 2009 09:19 PM

Also further down we have

						foreach( $methods as $_id => $_method )
						{
							if ( $_method['_data'] )
							{
								$_ids = explode( ",", $_method['module_assigned_to'] );
					
								if ( in_array( $product['product_id'], array_values( $_ids ) ) )
								{
									$ourrequest['extra_data'] = base64_encode( serialize( $_method['_data'] ) );
								}
							}
						}

$product['product_id'] is not set, however. Also, array_values call seems unnecessary looking at the code. I changed this to

						foreach( $methods as $_id => $_method )
						{
							if ( $_method['_data'] )
							{
								$_ids = explode( ",", $_method['module_assigned_to'] );
					
								if ( in_array( $product_id, $_ids ) )
								{
									$ourrequest['extra_data'] = base64_encode( serialize( $_method['_data'] ) );
								}
							}
						}