Jump to content


Issue information

  • #035054

  • Fixed

  • 2.5.0

  • 2.5.1

  • 2 - Fair


Issue Confirmations

  • Yes (0)No (0)
Photo

New Topic Generation and Notifications

Posted by on 13 December 2011 - 01:35 PM

Warning: Data missing in classes_like_composite::sendNotifications in /home/fundayf1/public_html/forum/admin/sources/classes/like/composite.php on line 543

Warning: Relationship ID missing in classes_like_registry::getKey in /home/fundayf1/public_html/forum/admin/sources/classes/like/composite.php on line 144

If a downloads category is set to post a new topic in the forums and that forum is then deleted we get the above error.

applications_addon/ips/downloads/sources/classes/topics.php

$this->forum	= $this->registry->getClass('class_forums')->allForums[ $category['coptions']['opt_topicf'] ];

$this->forum is set null as it doesn't exist in allForums.

Additionally an orphan topic is then created.

quick proposed fix;

$this->forum	= $this->registry->getClass('class_forums')->allForums[ $category['coptions']['opt_topicf'] ];

if ( ! $this->forum ) {
	return false;
}


I'd go with:
if ( empty( $this->forum['id'] ) )
{
	return false;
}


changed status to: Confirmed - General
changed severity to: 2 - Fair

TBH - I'm probably going to be moving over to the classPost API in the next release, so this will likely become a moot issue then.


changed status to: Fixed
changed fixed-in version to: 2.5.1

Rewrote using the post libraries, so this should be a non-issue now.






0 user(s) are reading this issue

0 members, 0 guests, 0 anonymous users