Jump to content


Issue information

  • #035469

  • Fixed

  • -

  • -

  • 0 - None Assigned


Issue Confirmations

  • Yes (0)No (0)
Photo

Notification of new comments to the articles

Posted by Sonya* on 18 January 2012 - 04:32 PM

When a comment is posted to the article I follow, user following it gets notification that uses the subject and text for email, not notification. It is $lang['ccs_comment_notification'].

The right notification message with the link to article seems to be used nowhere. It is defined as:

subject__ccs_comment_notification
<a href='%s'>%s</a> posted a comment on <a href='%s'>%s</a>

Found in admin/applications_addon/ips/ccs/sources/databases.php this code



		require_once( IPS_ROOT_PATH . 'sources/classes/like/composite.php' ); /* noLibHook */
		$this->_like = classes_like::bootstrap('ccs', $database['database_database'] . '_records');
		$this->_like->sendNotifications($record['primary_id_field'], array('immediate', 'offline'), array(
			'notification_key' => 'ccs_notifications',
			'notification_url' => $this->registry->ccsFunctions->returnDatabaseUrl($database['database_id'], 0, $record, $comment['comment_id']),
			'email_template' => 'ccs_comment_notification',
			'email_subject' => $_title,
			'build_message_array' => array(
				'NAME' => $row['members_display_name'],
				'POSTER' => $comment['poster_name'],
				'LINK' => $this->registry->ccsFunctions->returnDatabaseUrl($database['database_id'], 0, $record, $comment['comment_id']),
				'TITLE' => $_title,
				'TEXT' => $comment['comment_post']
			)
		));

You can see that like notification uses email_subject and email_template.


changed status to: Fixed

This looks to be largely a bug in the IPB like class.  I've resolved it for 3.3.0 and notifications seem to be sending properly locally now.


Can we have the patch for this issue in 3.2.3? We really need correct notification internal. Additionally there is no email notification sent on new comments.


I'm afraid I cannot build a patch for 3.2.x right now.  There have been many many changes between IP.Content 2.2.x and 2.3.0 and IP.Board 3.2.x and 3.3.0, so pulling out individual snippets of code to change is very challenging.


OK, will write ourselves.


Did you fix it? because we have the same and i think more people.


It will be fixed with IP.Board 3.3.0 + IP.Content 2.3.0.






1 user(s) are reading this issue

0 members, 1 guests, 0 anonymous users