Issue information
-
#035706
-
Not a Bug
-
-
-
-
-
0 - None Assigned
Issue Confirmations
-
Yes (0)No (0)
1
This is a weird situation, but.. I can kinda see the logic behind it.
If you use CDN, or remote image loading.. Minify should be off.. If it's on.. Then CSS content is served local.. but.. What if you want that? You just basically want to load the images remotely.. With minify enabled, your CSS is still pulled locally, minified, and images are served remotely.
It seems to work well, with one gallery exception, that being slideshow.
That, causes the ipgallery_slideshow.css template to be loaded from the remote CSS via minify.
so, something like
Shouldn't that more be..
Much like the print function is for IPB, so that it doesn't get passed through minify?
If you use CDN, or remote image loading.. Minify should be off.. If it's on.. Then CSS content is served local.. but.. What if you want that? You just basically want to load the images remotely.. With minify enabled, your CSS is still pulled locally, minified, and images are served remotely.
It seems to work well, with one gallery exception, that being slideshow.
$this->registry->output->addToDocumentHead( 'importcss', $this->settings['css_base_url'] . 'style_css/' . $this->registry->output->skin['_csscacheid'] . '/ipgallery_slideshow.css' );
That, causes the ipgallery_slideshow.css template to be loaded from the remote CSS via minify.
so, something like
<link rel="stylesheet" type="text/css" href="http://www.site.com/public/min/index.php?f=http://remote.site.com/public/style_css/css_18/ipgallery_slideshow.css"/>
Shouldn't that more be..
$this->registry->output->addToDocumentHead( 'raw', "<link rel='stylesheet' type='text/css' title='Main' media='screen,print' href='{$this->settings['css_base_url']}style_css/{$this->registry->output->skin['_csscacheid']}/ipgallery_slideshow.css'" );
Much like the print function is for IPB, so that it doesn't get passed through minify?
Looking at the current code in the "inludeCSS" template it seems already fixed, anyway this is something that should be handled at the core level rather then gallery alone since other files as well use the same "importcss" option to include CSS files.
Moving to IPB project.
Moving to IPB project.
If you use a CDN, minify needs to be off.
In that case, is there still a bug?
In that case, is there still a bug?
1 user(s) are reading this issue
0 members, 1 guests, 0 anonymous users
