• Content count

  • Joined

  • Last visited


About TSP

IPS Marketplace

  • Resources Contributor Total file submissions: 7

Recent Profile Visitors

102,867 profile views

TSP's Activity

  1. TSP added a post in a topic Can VNC please save the filtered forum list   

    Personally I would view it as more useful having it be an exclude list (or let the members chose whether the selected forums is what should be included OR excluded). 
    New forums can be added, and when you do it as an include list as it currently is, then your members will have to stay on top of it, making sure they know about new forums they might be interested in being added for themselves etc. Which also reduces the chance they'll find topics from those forums, even if they want to.
    I think it would be a good idea with some more filter options and to be able to save more than one "preset" for how to discover content, and it could be added as a tab or similar on top. 
  2. TSP added a post in a topic Loading Navigation twice - this sait & not only   

    The second occurrence is the mobile navigation.
    This is quite a common approach for menus on responsive sites. The reason being the menus are usually laid out quite differently on the mobile view and the desktop view. Which would make it impossible or at least very finicky to try and achieve it all with the same markup and just different CSS. It's easier to just have different markups to work with in that case.
  3. TSP added a comment on a blog entry Month in Review - June 2015   

    Gongratulations on switching to Git 
    Hope you'll enjoy it!
  4. TSP added a post in a topic Suggestion to improve rebuild process: go backwards   

    I've decided to at least try this idea. I can't see any disadvantages, if any IPS Developers could give me a good reason you don't already do this, then please do. And if there's no reason then I would wish you to implement this sort of idea into a future update. 
    Here is my changes: 
    Date: Sat Jun 27 23:33:13 2015 +0200 RebuildPosts rebuild backwards diff --git a/www/applications/core/extensions/core/Queue/RebuildPosts.php b/www/applications/core/extensions/core/Queue/RebuildPosts.php index ac35446..09a638b 100644 --- a/www/applications/core/extensions/core/Queue/RebuildPosts.php +++ b/www/applications/core/extensions/core/Queue/RebuildPosts.php @@ -63,6 +63,8 @@ class _RebuildPosts { return null; } + + $data['offset'] = $data['count'] + 1; return $data; } @@ -97,7 +99,7 @@ class _RebuildPosts catch( \RuntimeException $e ){} $where = ( is_subclass_of( $classname, 'IPS\Content\Comment' ) ) ? ( is_array( $classname::commentWhere() ) ? array( $classname::commentWhere() ) : array() ) : array(); - $select = $classname::db()->select( '*', $classname::$databaseTable, array_merge( $where, array( array( $classname::$databasePrefix . $classname::$databaseColumnId . ' > ?', $offset ) ) ), $classname::$databasePrefix . $classname::$databaseColumnId . ' ASC', array( 0, $this->rebuild ) ); + $select = $classname::db()->select( '*', $classname::$databaseTable, array_merge( $where, array( array( $classname::$databasePrefix . $classname::$databaseColumnId . ' < ?', $offset ) ) ), $classname::$databasePrefix . $classname::$databaseColumnId . ' DESC', array( 0, $this->rebuild ) ); $iterator = new \IPS\Patterns\ActiveRecordIterator( $select, $classname ); $last = NULL; @@ -107,10 +109,10 @@ class _RebuildPosts /* If the ID is greater than the max we started with, don't rebuild - we're done because this post and any newer will have been posted under 4.0 already */ - if( $item->$idColumn >= $data['count'] ) + /*if( $item->$idColumn >= $data['count'] ) { return NULL; - } + }*/ $member = \IPS\Member::load( $item->mapped('author') ); $extensions = \IPS\Application::load( $classname::$application )->extensions( 'core', 'EditorLocations' ); @@ -212,6 +214,6 @@ class _RebuildPosts throw new \OutOfRangeException; } - return array( 'text' => \IPS\Member::loggedIn()->language()->addToStack('rebuilding_stuff', FALSE, array( 'sprintf' => array( \IPS\Member::loggedIn()->language()->addToStack( $class::$title . '_pl', FALSE, array( 'strtolower' => TRUE ) ) ) ) ), 'complete' => $data['count'] ? ( round( 100 / $data['count'] * $offset, 2 ) ) : 100 ); + return array( 'text' => \IPS\Member::loggedIn()->language()->addToStack('rebuilding_stuff', FALSE, array( 'sprintf' => array( \IPS\Member::loggedIn()->language()->addToStack( $class::$title . '_pl', FALSE, array( 'strtolower' => TRUE ) ) ) ) ), 'complete' => $data['count'] ? ( round( 100 - (100 / $data['count'] * $offset), 2 ) ) : 100 ); } -} \ No newline at end of file +} diff --git a/www/system/Task/Task.php b/www/system/Task/Task.php index 7b84ffc..76d49fe 100644 --- a/www/system/Task/Task.php +++ b/www/system/Task/Task.php @@ -49,10 +49,18 @@ class _Task extends \IPS\Patterns\ActiveRecord throw new \InvalidArgumentException; } + $offset = 0; + if ( method_exists( $extensions[ $key ], 'preQueueData' ) ) { $class = new $extensions[ $key ]; $data = $class->preQueueData( $data ); + + if( isset( $data['offset'] ) and $data['offset'] != 0 ) + { + $offset = $data['offset']; + } + if ( $data === NULL ) { return; @@ -91,7 +99,8 @@ class _Task extends \IPS\Patterns\ActiveRecord 'date' => time(), 'app' => $app, 'key' => $key, - 'priority' => $priority + 'priority' => $priority, + 'offset' => $offset ) ); \IPS\DB::i()->update( 'core_tasks', array( 'enabled' => 1 ), array( '`key`=?', 'queue' ) );  
  5. TSP added a post in a topic Post anonymously Topics or Files   

    I've provided a more detailed reply to you in my support topic. Short version is that I started proper work on it this week and that I feel close to releasing the IPS 4 version, that will do nearly all the things it did in 3.4.
    However I don't have any time available to make this plugin do more than what I need it to do myself, but I do like your idea on it's usage.
  6. TSP added a post in a topic Error Codes Conventions   

    Could you get this into the documentation section? I was looking for this and I first spent 5-10 minutes trying to find it in the doc section, before I eventually managed to find it by a search. 
  7. TSP added a topic in Company Feedback   

    Your new release notes section is nice
    I noted that you had it in category view for a few days, and I didn't like that. So **in secret** I wanted you to change back to how it was with the "plain text document"-style.
    I see that you've refreshed the look now, and I really really like it on desktop. Nice job, @Rikki (I assume he did it). I'm still not quite fond of what seems to be your default mobile look in circumstances where you have such menu styles; where you'll get this huge menu list at the top before you then have to scroll down to the actual contents. I think it should collapse into a dropdown then or just show the selected menu item at the top and then have a "Expand"-button to display all the others. 
    But on desktop it's really nice! And I assume that it once again is a display of the powers of custom pages in Pages.
    • 10 replies
  8. TSP added a post in a topic Easy mode theme colorizer   

    My reasoning for using this is that it seems to find nearby colors to match and also applies same color to variables with the same color.
     If I could input the color codes to get me started I would feel it be more efficient than going through all of the variables myself and I would probably  be less likely to do changes that doesn't match well. 
    I would still edit the variables individually too, but without having to change the main blue everywhere myself for instance
  9. TSP added a topic in Product Feedback   

    Easy mode theme colorizer
    The colorizer seems like a good idea, but I don't understand why I can't paste a color code in it? I need the colors to match an exact input color, so I was a bit surprised I could not do it.

    • 2 replies
  10. TSP added a topic in Product Feedback   

    Suggestion to improve rebuild process: go backwards
    There could be a good reason it goes from the oldest to the newest post, but if it isn't, then please consider this. 
    It seems to me the rebuild goes from the first post until the last. I would want the rebuild to start with the newest post (after the upgrade) and then finish with the oldest one. 
    There are two core advantages to this approach: 
    The feeling of a slow rebuild process will be less prevalent since you'll be more likely to have 90% of the visited content within the timeframe already be rebuilt. You'll avoid rebuilding content that have been posted after the upgrade. **** I have yet to confirm this, but it seems the rebuild process just does WHERE pid > X where X is the last postID it rebuilt. It doesn't seem to have a clearly defined stopping point, which means it'll continue as long as it received 50 items for the previous cycle. Which, depending on the page activity, would mean it would have to do more cycles than actually necessary. 
    • 2 replies
  11. TSP added a post in a topic Bring back CSS/JS IPS4 Framework Documentation   

    And also a hosted PHPDoc-section for the 4.X code please
  12. TSP added a post in a topic Topic navigation on mobile   

    That is amazing Rikki, everything you need, clean and simple. Thanks for finally doing this!
  13. TSP added a post in a topic Theme updates (code changes)   

    ​I guess to maybe go into more details on what the tools exactly will do and how they work.
  14. TSP added a topic in Product Feedback   

    Consider responsive breakpoint values being a theme setting
    @Rikki: could you consider having the breakpoints for responsive be definable with a theme setting in default skins?
    Otherwise I either have to copy all the CSS-rules within the core_responsive.css etc. into my own responsive CSS (and not include the default responsive) or change all the values within all the places where the responsive breakpoints are used. 
    So wouldn't it be better if we could set these breakpoints from a theme setting? One for tablet and one for mobile. 
    • 1 reply
  15. TSP added a file in Translations   

    Norwegian (Norsk, bokmål) for all IPS-apps except Commerce v1.0.5
    This is the Norwegian translation of IPS 4, the remainder of this text will be in Norwegian.
    Dette er den norske språkpakken for Invision Power Suite 4. Oversettelsen er gjort til bokmål.
    Disse applikasjonene er oversatt:
    System / CoreForum - IP.ForumsBlogger - IP.BlogKalender - IP.CalendarGalleri - IP.GalleryNedlastninger - IP.DownloadsSider - IP.PagesOversettelsen ble eksportert og testet med IPS 4.0.3. 
    Jeg setter veldig pris på om du kommer med tilbakemeldinger, tips til endringer, melder inn feil osv. i dette emnet: http://community.invisionpower.com/topic/409197-ips-4-norwegian-translation-norsk-bokmål-for-blog-calendar-and-forums/
    Du kan også ta direkte kontakt med meg her i forumet eller min profil TSP på Diskusjon.no.
    • 0 reviews